Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ros2 OpenCV3 #230

Open
wants to merge 3 commits into
base: ros2
Choose a base branch
from
Open

Ros2 OpenCV3 #230

wants to merge 3 commits into from

Conversation

klintan
Copy link

@klintan klintan commented Apr 12, 2020

Based on the eminent work by @kunaltyagi on PR #202 here is one for ROS2, but not as invasive. Since it still relies on the original darknet repo in use today (hopefully so that this can be merge easier).

I have another bug in Mac that I need to fix, but this should at least make it work out of the box.

Let me know if there is anything missing or any other changes needed before merge.

edit: might leave the mac bug be for a while, use make sure to disable the opencv viewing --param image_view.enable_opencv:=false. Reason for this not working is that you can't update the ui in a background thread on mac.

@klintan
Copy link
Author

klintan commented Apr 25, 2020

@mbjelonic I know times are strange and you are probably very busy. Would love to get this one going, or some feedback on it to get this in as fast as possible :)

@mbjelonic
Copy link
Collaborator

@klintan Thanks for your work! I will check your PR asap.

@klintan
Copy link
Author

klintan commented Oct 16, 2020

Just wanna circle back on this one, have you had the time to take a look at this ? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants