Merge pull request erikdoe#132 from madsolar8582/fixbufferboundaries

Fix for clang static analyzer issue CWE-119
leepenny · May 11, 2015 · da6dc18 · da6dc18
2 parents 3413267 + 90ac2e9
commit da6dc18
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Source/OCMock/NSInvocation+OCMAdditions.m b/Source/OCMock/NSInvocation+OCMAdditions.m
@@ -364,8 +364,8 @@ - (NSString *)cStringDescriptionAtIndex:(NSInteger)anInt
  char *cStringPtr;
 
  [self getArgument:&cStringPtr atIndex:anInt];
- strncpy(buffer, cStringPtr, 100);
- strcpy(buffer + 100, "...");
+ strlcpy(buffer, cStringPtr, sizeof(buffer));
+ strlcpy(buffer + 100, "...", (sizeof(buffer) - 100));
  return [NSString stringWithFormat:@"\"%s\"", buffer];
 }