Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STEP1_PR 후 리팩토링 #6

Closed
leeari95 opened this issue Jan 6, 2022 · 0 comments
Closed

STEP1_PR 후 리팩토링 #6

leeari95 opened this issue Jan 6, 2022 · 0 comments
Assignees
@llghdud921 @leeari95
Projects
STEP1

Comments

@leeari95
Copy link
Owner

leeari95 commented Jan 6, 2022

No description provided.

@leeari95 leeari95 added this to To do in STEP1 Jan 6, 2022
@leeari95 leeari95 moved this from To do to In progress in STEP1 Jan 6, 2022
leeari95 added a commit that referenced this issue Jan 6, 2022
@leeari95
refactor: 테스트 코드에 중복되는 부분 리팩토링 #6
afa5c2a
llghdud921 added a commit that referenced this issue Jan 6, 2022
@llghdud921
refactor: test code내 주석 및 줄바꿈 수정 #6
dd21787
leeari95 added a commit that referenced this issue Jan 6, 2022
@leeari95
refactor: Image의 프로퍼티 네이밍을 명확하게 수정 #6
7bd46d8
llghdud921 added a commit that referenced this issue Jan 6, 2022
@llghdud921
refator: Content-type,MultipartForm String값 상수로 정의 #6
513ae69 
- MultiPartForm 프로토콜을MultiPartFormProtocol로 변경
- MultipartForm, contentType enum 구현 및 관련 코드 수정
- 오버로딩된 request 함수명 명확하게 개선
- 들여쓰기 컨벤션 개선
leeari95 added a commit that referenced this issue Jan 6, 2022
@leeari95
refactor: 에러의 케이스중 네이밍을 명확하게 개선 #6
e3b81a7
llghdud921 added a commit that referenced this issue Jan 6, 2022
@llghdud921
refactor: Parser, Parsable에 JSON을 추가한 네이밍으로 개선 #6
05fddcb
leeari95 added a commit that referenced this issue Jan 6, 2022
@leeari95
refactor: Network 프로퍼티에 접근제어 부여하여 개선 #6
e44134c
llghdud921 added a commit that referenced this issue Jan 6, 2022
@llghdud921
refactor: Address를 APIAdress로 네이밍 개선 #6
d553f99
leeari95 added a commit that referenced this issue Jan 7, 2022
@leeari95
refoctor: 상품수정, Secret 조회 중복되는 부분을 메소드로 분리 #6
a65df63 
- 코드 수정 후 테스트 진행하다가 네이밍 수정안된 부분 수정
- 테스트의 iOS Deployment Target을 15에서 14로 수정
llghdud921 added a commit that referenced this issue Jan 7, 2022
@llghdud921
refactor: 테스트코드 내 force Unwrapping 옵셔널하게 수정 #6
2d57799
@leeari95 leeari95 moved this from In progress to Done in STEP1 Jan 7, 2022
llghdud921 added a commit that referenced this issue Jan 10, 2022
@llghdud921
fix: multipartform body구성 시 마지막 boundary 추가 #6
33e0482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llghdud921 llghdud921

@leeari95 leeari95

Labels
None yet
Projects
No open projects
STEP1
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llghdud921 @leeari95