Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STEP1_리팩토링 #4

Closed
7 tasks done
leeari95 opened this issue Jan 4, 2022 · 0 comments
Closed
7 tasks done

STEP1_리팩토링 #4

leeari95 opened this issue Jan 4, 2022 · 0 comments
Assignees
@llghdud921 @leeari95
Projects
STEP1

Comments

@leeari95
Copy link
Owner

leeari95 commented Jan 4, 2022 •
edited
Loading

리팩토링

  • 접근제어
  • ImageFile 내부에 Form 타입 이동시켜주기
  • Products CodingKeys 내부 케이스 rawValue 없는건 합쳐주기
  • Secret 네이밍 수정
  • NetworkError errorDescription 만들어주기
  • protocol 분리해주기
  • 이니셜라이저 체크
leeari95 added a commit that referenced this issue Jan 4, 2022
@leeari95
refactor: NetworkManager 내부 리팩토링 #4
be0cb43 
- 줄바꿈 최소한으로 제거
- 가독성 향상을 위한 변수 대입
- private 메소드를 extension으로 분리
- 접근제어 추가
@leeari95 leeari95 added this to To do in STEP1 Jan 4, 2022
@leeari95 leeari95 moved this from To do to In progress in STEP1 Jan 4, 2022
llghdud921 added a commit that referenced this issue Jan 4, 2022
@llghdud921
refactor: NetworkError 내부 리팩토링 및 ProductSecret 타입명 변경 #4
27fa33f
leeari95 added a commit that referenced this issue Jan 4, 2022
@leeari95
refactor: MultipartForm 프로토콜을 Protocol 그룹으로 이동 #4
e73b5fc 
- NetworkError에서 statusCode의 연관값 타입을 수정
- Vendors의 들여쓰기를 수정
llghdud921 added a commit that referenced this issue Jan 4, 2022
@llghdud921
refactor: Products 내 CodingKeys 수정 #4
a54a4ce
llghdud921 added a commit that referenced this issue Jan 5, 2022
@llghdud921
refactor: NetworkManager내 multipart image 경로 수정 #4
aa5b4d2
@leeari95 leeari95 moved this from In progress to Done in STEP1 Jan 5, 2022
leeari95 added a commit that referenced this issue Jan 6, 2022
@leeari95
refactor: multipartFormRequest 메소드 내부에 request의 헤더를 추가하는 부분 수정 #4
1bde0bd 
- JSON이 아니라 multipart/fome-data로 수정
- boundary 변수를 함수 내부에 추가하여 활용하도록 수정
- 테스트 파일 내부 그룹으로 분리
llghdud921 added a commit that referenced this issue Jan 6, 2022
@llghdud921
refactor: MockURLProtocol내 주석 제거 #4
cfd7f09
leeari95 added a commit that referenced this issue Jan 6, 2022
@leeari95
refactor: NetworkConstant를 Address와 HTTPMethod로 분리 #4
79c207a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@llghdud921 llghdud921

@leeari95 leeari95

Labels
None yet
Projects
No open projects
STEP1
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llghdud921 @leeari95