Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog app - integration specs for views and fix n+1 problems #9

Merged
merged 7 commits into from
Nov 8, 2022

Conversation

learnwithalfred
Copy link
Owner

The following has been completed

  • Make sure that the N+1 problem is solved when fetching all posts and their comments for a user. ✔️
  • Use Capybara to write integration tests for each view in your project.
  • Test written for
    • User index page:
    • user show page:
    • User post index page:
    • Post show page:

Screenshot 2022-11-08 at 13 45 44

Copy link

@ShahierNashaat ShahierNashaat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @learnwithalfred,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

To Highlight 💯

  • All tests are passing ✔️
  • Correct use of GitFlow ✔️
  • Descriptive commit messages ✔️
  • Professional looking pull request ✔️
  • Your readme looks professional ✔️
  • Good overall design ✔️
  • Your code is clean and well documented ✔️

Approved 👌 👌 👌

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@learnwithalfred learnwithalfred merged commit 7cdf2a7 into dev Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants