Blog app - Views #7
Conversation
There was a problem hiding this comment.
Hello @learnwithalfred 👋 ,
Good job so far! 👍
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🍾
- I like your UI 👍
- Clean code 🧹
- Cool that you used tailwind 🏄
- Linter checks passing ✔️
- Awesome that you added a seed 🌱
Required Changes ♻️
Check the comments under the review.
Optional suggestions 💭
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @Lucas-Masaba in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
- In your posts index you are required to use the
recent_commentsmethod in your post model to display the 5 most recent comments. 👍
app/views/users/show.html.erb
Outdated
| </p> | ||
| <h1 class="m-4 text-3xl font-extrabold tracking-tight leading-none text-gray-900"> | ||
| Posts</h1> | ||
| <%@posts.each_with_index do |post, index| %> |
There was a problem hiding this comment.
- Awesome job here. But, you are required to use the
recent_postsmethod in your user model to display the 3 most recent posts. 👍
There was a problem hiding this comment.
This is not part of the current requirement. It was made for because of styling. Why are you looking for errors?
@Lucas-Masaba
You are going beyond your requirements. You need to check the requirements before passing review.
There was a problem hiding this comment.
Hi @learnwithalfred ,
STATUS: APPROVED! 🥇 💯
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- All linters passed
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Views has been created for users
Remember the project is styled with tailwind CSS. You can start application by running
./bin/devRun
rails db:seedto seed test data for testing#Screenshots