Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog app - controllers #5

Merged
merged 8 commits into from
Oct 31, 2022
Merged

Blog app - controllers #5

merged 8 commits into from
Oct 31, 2022

Conversation

learnwithalfred
Copy link
Owner

@learnwithalfred learnwithalfred commented Oct 31, 2022

The following changes has been completed

  • For each URL you should create ✔️

    • A route.
    • An action in the correct controller.
    • A view file.
  • View files should include only placeholders written in plain HTML ✔️

  • Make sure that you added code to handle only the 4 required URLs. ✔️

Run rails db:seed to data in database

Screenshots

Screenshot 2022-10-31 at 11 32 47

Screenshot 2022-10-31 at 11 33 04

Screenshot 2022-10-31 at 11 33 26

Screenshot 2022-10-31 at 11 10 19

Screenshot 2022-10-31 at 11 33 40

Copy link

@uwadonat uwadonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @learnwithalfred,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Descriptive pull request message ✔️
  • No linter errors ✔️
    image2

Status: Approved ✔️✔️✔️

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100%.
Please, remember to tag me @uwadonat in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@learnwithalfred learnwithalfred merged commit f2caa1d into dev Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants