-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog App: validations and model specs #3
Conversation
Hi @learnwithalfred, While you made a great effort in this project, I cannot proceed to review your code. Invalid Code Review RequestKindly collaborate with your coding partner for this projectYour Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏 Cheers and Happy coding!👏👏👏 Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise. Invalid Code Review Request does not count into the code reviews limit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
STATUS: REQUIRES CHANGES ♻️
Hi @learnwithalfred 👋,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights 🎯
✔️ Descriptive PR
✔️ Done model validation
✔️ No linter errors
✔️ Good commit history
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
You can also consider:
- N/A
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**STATUS: APPROVED 🟢 **
Hi @learnwithalfred ,
Great work on making the changes requested by a previous reviewer 👏🏻
Highlights:
✔️ All specs are passing
✔️ All linters are passing
✔️ Correct gitflow
✔️ Professional documentation
Your project is complete! . There is nothing else to say other than... it's time to merge it 🍾🚢 . Congratulations! 🎉💯🌟
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me [@ShoiraTa] in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have limited number of reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.
Thank you |
Completed Project requirements