Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog App - processing data in models #2

Merged
merged 7 commits into from
Oct 27, 2022
Merged

Blog App - processing data in models #2

merged 7 commits into from
Oct 27, 2022

Conversation

learnwithalfred
Copy link
Owner

The following requirements have been completed

Added:

  • A method that returns the 3 most recent posts for a given user.
  • A method that updates the posts counter for a user.
  • A method which returns the 5 most recent comments for a given post.
  • A method that updates the comments counter for a post.
  • A method that updates the likes counter for a post.

Copy link

@DeliceLydia DeliceLydia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @learnwithalfred,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Check the comments under the review.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


_As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form

app/models/post.rb Show resolved Hide resolved
app/models/post.rb Outdated Show resolved Hide resolved
app/models/like.rb Show resolved Hide resolved
app/models/user.rb Outdated Show resolved Hide resolved
Copy link

@rustam-tolipov rustam-tolipov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @learnwithalfred,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Developer-512px-10

Highlights

  1. No Linters errors 💯
  2. All requirements are complete 💯

Optional suggestions

No optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@learnwithalfred
Copy link
Owner Author

Thank you soo mcuh

@learnwithalfred learnwithalfred merged commit d3580c9 into dev Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants