Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog app: add devise #10

Merged
merged 7 commits into from
Nov 9, 2022
Merged

Blog app: add devise #10

merged 7 commits into from
Nov 9, 2022

Conversation

learnwithalfred
Copy link
Owner

Completed

  • Remove current_user method in ApplicationController, devise will provide us with one ✔️
    • Can register a new user.
    • User logs in with a combination of email and password.
    • Hashed password should be stored in the database.
    • Ask for confirmation of email.
    • Can reset password.

Screenshot 2022-11-09 at 12 52 08

Screenshot 2022-11-09 at 12 52 26

Copy link

@sja-thedude sja-thedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Project Approved 👍

Hi @learnwithalfred, This is @sja-thedude your code reviewer.

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights:

  • All linters passing
  • All requirements completed
  • Professional readme

giphy

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me [@sja-thedude] in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@learnwithalfred learnwithalfred merged commit 1796dbf into dev Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants