Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dependency for the albert example #611

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samsja
Copy link
Contributor

@samsja samsja commented May 13, 2024

Context

this is just a small PR to fix some dependencies with the albert example. The old version of dataset and wandb being not compatible with the current hf and wandb hub

@samsja
Copy link
Contributor Author

samsja commented May 13, 2024

it seems that the CI is failing for an error linked to this issue : #610

EDIT: CI problem Should be fixed by this PR : #612

@mryab
Copy link
Member

mryab commented Jun 9, 2024

@samsja Thanks for the PR! The fix for CI is merged to master, can you rebase your branch on it and try again?

Also, can you please confirm that the script works with these dependencies updated?

@samsja
Copy link
Contributor Author

samsja commented Jun 10, 2024

@samsja Thanks for the PR! The fix for CI is merged to master, can you rebase your branch on it and try again?

Also, can you please confirm that the script works with these dependencies updated?

yes the script is now working with this dependency. I just rebased the branch

fixed requirements for albert example

fix dataset versions (learning-at-home#1)

Revert "fixed albert example"

This reverts commit cccce0c.

remove accelerate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants