Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Mathlib/Init/ZeroOne): rename Mathlib.Init.ZeroOne to Mathlib.Algebra.Group.ZeroOne #14642

Closed
wants to merge 14 commits into from

Conversation

Komyyy
Copy link
Collaborator

@Komyyy Komyyy commented Jul 11, 2024

@Komyyy Komyyy added awaiting-CI tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Jul 11, 2024
Copy link

github-actions bot commented Jul 11, 2024

PR summary 1bd32f1596

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Init.ZeroOne -41
Mathlib.Algebra.Group.ZeroOne 41

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

@YaelDillies
Copy link
Collaborator

Sorry, I'll veto the Order.Defs change. I'm working on a bigger rework and it would help not having weird diffs because someone moved the file.

@Komyyy Komyyy added WIP Work in progress and removed awaiting-CI labels Jul 11, 2024
@Komyyy
Copy link
Collaborator Author

Komyyy commented Jul 11, 2024

Sorry, I'll veto the Order.Defs change. I'm working on a bigger rework and it would help not having weird diffs because someone moved the file.

I see, @YaelDillies.

scripts/noshake.json Outdated Show resolved Hide resolved
@Ruben-VandeVelde Ruben-VandeVelde added the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 11, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 11, 2024
@YaelDillies
Copy link
Collaborator

Can you remove the Order.Defs changes, then?

@Komyyy
Copy link
Collaborator Author

Komyyy commented Jul 11, 2024

@YaelDillies Yes.

@Komyyy Komyyy changed the title chore(Mathlib/Init/*): remove 3 Init files chore(Mathlib/Init/ZeroOne): rename Mathlib.Init.ZeroOne to Mathlib.Algebra.ZeroOne Jul 11, 2024
@Komyyy Komyyy added awaiting-CI and removed WIP Work in progress labels Jul 11, 2024
@jcommelin
Copy link
Member

You seem to also be moving the to_additive frontend to a new file. Is that intentional?

@Komyyy
Copy link
Collaborator Author

Komyyy commented Jul 15, 2024

@jcommelin Yes, this PR moves attribute [to_additive] commands in Mathlib.Init.ZeroOne to better home.

@YaelDillies
Copy link
Collaborator

The diff is sadly messed up. Can you make sure that git understands your to_additive changes as moves?

@Komyyy Komyyy added the WIP Work in progress label Jul 15, 2024
@Komyyy Komyyy added awaiting-CI and removed WIP Work in progress labels Jul 15, 2024
@Komyyy
Copy link
Collaborator Author

Komyyy commented Jul 15, 2024

@YaelDillies
I rebased the commit to make git recognize this change as a rename. But the diff didn't change.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 17, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib (this label is automatically managed by a bot) label Jul 17, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label Jul 17, 2024
@Komyyy Komyyy added awaiting-CI and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) labels Jul 17, 2024
@j-loreaux j-loreaux added the awaiting-author A reviewer has asked the author a question or requested changes label Jul 17, 2024
@Komyyy Komyyy changed the title chore(Mathlib/Init/ZeroOne): rename Mathlib.Init.ZeroOne to Mathlib.Algebra.ZeroOne chore(Mathlib/Init/ZeroOne): rename Mathlib.Init.ZeroOne to Mathlib.Algebra.Group.ZeroOne Jul 18, 2024
@Komyyy Komyyy added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 18, 2024
@j-loreaux
Copy link
Collaborator

Thanks!

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Jul 18, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jul 18, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 18, 2024

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Jul 18, 2024
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jul 18, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Mathlib/Init/ZeroOne): rename Mathlib.Init.ZeroOne to Mathlib.Algebra.Group.ZeroOne [Merged by Bors] - chore(Mathlib/Init/ZeroOne): rename Mathlib.Init.ZeroOne to Mathlib.Algebra.Group.ZeroOne Jul 18, 2024
@mathlib-bors mathlib-bors bot closed this Jul 18, 2024
@mathlib-bors mathlib-bors bot deleted the Komyyy/Init branch July 18, 2024 08:27
@adomani adomani mentioned this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants