Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.1 #39

Merged
merged 31 commits into from
Mar 19, 2020
Merged

v1.4.1 #39

merged 31 commits into from
Mar 19, 2020

Conversation

JoaoAndreSa
Copy link
Contributor

@JoaoAndreSa JoaoAndreSa commented Mar 19, 2020

Change Log

All notable changes introduced by this new version are documented here.

[1.4.1] - 2020-03-19

Added

  • Added a new global timeout for all node communication that can be configured by setting the environment variable CONN_TIMEOUT

Changed

  • Updated all dependencies (particularly important is the new version of Onet 3.2.0 that includes better error tracking)
  • Switched from errors.new to fmt.Errorf (the latter keeps the stack trace)
  • Removed the redundant isLeaf() condition for the SendToChildren call
  • Renamed some tmp variables for easy code readability
  • Conditions no longer use == false or == true
  • Renamed main exec package to main
  • Reorganized the app folder files: /app/ is changed to /cmd/[application_name]/

Fixed

  • Fixed the error generated by the tn.Config() function by moving it out of the NewProtocol(tn *onet.TreeNodeInstance, conf *onet.GenericConfig) and adding it to right before this function call. "...this way, only the root will actually set the config for the whole tree, ensuring that every node gets it before starting."

@JoaoAndreSa
Copy link
Contributor Author

Quick question do you know how to remove this ci/dockercloud check? I tried changing the branch protection rule, but it's still here...

@mickmis
Copy link
Contributor

mickmis commented Mar 19, 2020

Quick question do you know how to remove this ci/dockercloud check? I tried changing the branch protection rule, but it's still here...

It was the Docker Cloud webhook, I removed it so it should be gone now.

lib/constants.go Outdated Show resolved Hide resolved
@JoaoAndreSa JoaoAndreSa merged commit ad5b07f into master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants