Tags: ldir-EDB0/sqm-scripts
Tags
Fix logic error in do_modules preventing modules from loading. Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Nuke $IPT_MASK_STRING. Since we're not always doing the masking in the same way, simply setting IPT_MASK_STRING to an empty string is not always enough to turn off masking. So rather get rid of it; the proper way to turn off masking is to set the mask to 0xffffffff.
Effectively revert 85bfc4c The idea behind the reverting commit was that sqm will be started several times during boot-up if it is instantiated on an interface that receives hotplug events. At the point before 85bfc4c sqm was started three times, ones by init.d? and twice by hotplug. This seemed quite involved and wasteful, so we tried to reduce the idle work to the two hotplug restarts (guided by the observation that the two hotplug restarts together took almost as long as the initial start). The assumption was that all interfaces valid for sqm would receive hotplug events dring start-up. See https://forum.openwrt.org/viewtopic.php?id=60903 for an example of a valid sqm configuration that does not receive hotplug events. This configuration is described and advertised in the openwrt wiki as bridged AP, see https://wiki.openwrt.org/doc/recipes/bridgedap With this commit reverted sqm will increase start-up times by roughly 10 seconds, a small price to pay to have sqm work after a reboot on valid, recommended openwrt configurations. Since a real revert did not work this effectively undoes 85bfc4c manually. Signed-off-by: Sebastian Moeller <[email protected]>
PreviousNext