Introducing a configuration object #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private function getEncoder(): Parsing\Encoder | ||
| { | ||
| if ($this->encoder === null) { | ||
| $this->encoder = new Parsing\Parser(); |
There was a problem hiding this comment.
typo Parsing\Encoder?
There was a problem hiding this comment.
I just saw that Parser implements Encoder, sorry
lcobucci
force-pushed
the
feature/config-object
branch
from
c15d27b
to
c5ab785
Compare
lcobucci
changed the title
| /** | ||
| * @var Parser | ||
| */ | ||
| private $parser; |
There was a problem hiding this comment.
These values are potentially also |null
lcobucci
force-pushed
the
feature/config-object
branch
2 times, most recently
from
84b002e
to
c7d226e
Compare
lcobucci
force-pushed
the
feature/config-object
branch
from
c7d226e
to
1a476a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anything else @Ocramius?