Update getPassphrase PHPDoc
#422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
previously requested changes
Sep 27, 2020
lcobucci
approved these changes
Sep 29, 2020
Making sure we don't have to handle null cases while using it.
lcobucci
dismissed
Ocramius’s stale review
Code updated, thanks for the review @Ocramius
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The property
passphrasecan benullor a string.I propose to indicate it in the header.
If you really want to return a string, the constructor could be changed in favour of
public function __construct($content, $passphrase = '')Let me know if you prefer the later.