Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconnect to default server if custom server fails. #7593

Merged

Conversation

Ruk33
Copy link
Collaborator

@Ruk33 Ruk33 commented May 31, 2022

Fixes

Issue Number: #7586

What is the current behavior?

When the user uses a custom server and it fails to
connect, no default reconnection is made.

What is the new behavior?

When the user uses a custom server and it fails, it
will roll back to the default one.

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

Copy link
Member

@jessopb jessopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is better.

@jessopb jessopb merged commit c5b018a into master Jun 1, 2022
@jessopb jessopb deleted the 7586-handle-unavailable-custom-hub-servers-on-restart branch June 1, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants