Allow expressions as logging keys (JuliaLang#37036)

These will be converted to Symbols, similar to how positional args are handled

base/logging.jl

@@ -314,10 +314,10 @@ function process_logmsg_exs(_orig_module, _file, _line, level, message, exs...)
  _module = _orig_module
  kwargs = Any[]
  for ex in exs
- if ex isa Expr && ex.head === :(=) && ex.args[1] isa Symbol
+ if ex isa Expr && ex.head === :(=)
  k,v = ex.args
  if !(k isa Symbol)
- throw(ArgumentError("Expected symbol for key in key value pair `$ex`"))
+ k = Symbol(k)
  end
 
  # Recognize several special keyword arguments

test/logging.jl

@@ -44,7 +44,7 @@ end
  foo_val = 10
  bar_val = 100
  logs,_ = collect_test_logs() do
- @info "test" bar_val progress=0.1 foo=foo_val 2*3 real_line=(@__LINE__)
+ @info "test" bar_val progress=0.1 foo=foo_val 2*3 bar(x)=1.2 real_line=(@__LINE__)
  @info begin
  value_in_msg_block = 1000.0
  "test2"
@@ -69,6 +69,7 @@ end
  @test kwargs[:progress] == 0.1
  @test kwargs[:foo] === foo_val
  @test kwargs[Symbol(:(2*3))] === 6
+ @test kwargs[Symbol(:(bar(x)))] === 1.2
 
  # Keyword values accessible from message block
  record2 = logs[2]