Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: responsiveness issue#5693 #5724

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

AlfiyaSiddique
Copy link
Contributor

Description

This PR fixes #5693

Notes for Reviewers
This PR contains minor style fixes for the mobile size of a section on the blog page.

Signed commits

  • Yes, I signed my commits.

Outcome

Recording.2024-07-24.223815.mp4

Signed-off-by: Alfiya Siddique <[email protected]>
Signed-off-by: Alfiya Siddique <[email protected]>
@l5io
Copy link
Contributor

l5io commented Jul 24, 2024

🚀 Preview for commit 039d787 at: https://66a139ab9b9eab092ebebda6--layer5.netlify.app

@AlfiyaSiddique
Copy link
Contributor Author

Attached a recording of the outcome, let me know if it looks good or if you have any feedback. Also, let me know about the section Related Blogs if it also needs to be responsive as part of this issue.

@hargunkaur286
Copy link
Member

@AlfiyaSiddique This looks good to me! Can you please confirm that when we reach the related blogs section, it does become responsive once we refresh the page(after reaching the desired responsiveness), right?

@hargunkaur286
Copy link
Member

@AlfiyaSiddique There's one issue that you can solve as a part of this PR, make sure that "Layer5" starts from the next section, i.e. from below the image and is centered aligned on this page only. Below is a screenshot of the same. Let me know if it makes sense.
Screenshot 2024-07-25 at 2 55 08 PM

@AlfiyaSiddique
Copy link
Contributor Author

@hargunkaur286 correct the Related Blogs does fit in properly after refreshing the page so no change is needed.
Will make the change for the Layer5 Badges Section and ping you.
Thanks for the feedback.

Signed-off-by: Alfiya Siddique <[email protected]>
@github-actions github-actions bot added area/blog New posts or new blog functionality area/core-styles labels Jul 27, 2024
@l5io
Copy link
Contributor

l5io commented Jul 27, 2024

🚀 Preview for commit 3d9b4ae at: https://66a51a7c975f4c44be977ae2--layer5.netlify.app

@AlfiyaSiddique
Copy link
Contributor Author

AlfiyaSiddique commented Jul 27, 2024

Hey @hargunkaur286!
The fix for the Layer5 Badges section is done. Do let me know if need any other change.

@hargunkaur286
Copy link
Member

Thank you for the contribution @AlfiyaSiddique This looks good to me!

@Ashparshp
Copy link
Contributor

@AlfiyaSiddique Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we''ll probably don't want to change site-wide css declarations @AlfiyaSiddique , as it may cause undesired behavior on other pages.

@vishalvivekm
Copy link
Member

img.badge-modal{
max-width:95%; // prev 625px;
}

It's a bit too big imo.
image

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another responsiveness issue:
@AlfiyaSiddique @Ashparshp @hargunkaur286
Screen Shot 2024-07-29 at 01 16 22

@hargunkaur286
Copy link
Member

@vishalvivekm this issue resolves when we refresh the page, that's why didn't request for it. Is it valid?

@vishalvivekm
Copy link
Member

@vishalvivekm this issue resolves when we refresh the page, that's why didn't request for it. Is it valid?

✔️
Thank you, just confirmed this on my 📱

Is it valid?

Quite not.

@l5io
Copy link
Contributor

l5io commented Jul 28, 2024

🚀 Preview for commit 26b2898 at: https://66a6a29cc499827ed3ad4dcd--layer5.netlify.app

@AlfiyaSiddique
Copy link
Contributor Author

Is it valid?

Quite not.

@vishalvivekm What's quite not valid, can you please describe?
Do you want me to change the image width here?

img.badge-modal{
max-width:95%; // prev 625px;
}

The review comments are quite not clear to me so confirming!

@Ashparshp
Copy link
Contributor

@hargunkaur286 we're good to go with this PR right?

@Ashparshp
Copy link
Contributor

@AlfiyaSiddique Thanks for your contribution, let's discuss this on the website's call. Please add this as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Aug 12, 2024

🚀 Preview for commit 74d8dfa at: https://66b9f33ca3dcf17da5b486d0--layer5.netlify.app

@Muhammed-Moinuddin
Copy link
Contributor

LGTM !

@Ashparshp
Copy link
Contributor

@AlfiyaSiddique @hargunkaur286, is there anything more to update, or is this good to go?

@AlfiyaSiddique
Copy link
Contributor Author

@Ashparshp nothing from my side. @hargunkaur286 let me know if any more changes are needed

@Ashparshp
Copy link
Contributor

Thank you @AlfiyaSiddique.

@AlfiyaSiddique
Copy link
Contributor Author

@vishalvivekm, just a gentle reminder to review this PR when you get a chance so it can proceed further. Thanks!

@Ashparshp
Copy link
Contributor

@vishalvivekm @sudhanshutech //

@sudhanshutech
Copy link
Member

@Ashparshp is this still needed? Have you clarified the fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog New posts or new blog functionality area/core-styles
Development

Successfully merging this pull request may close these issues.

Improve the mobile responsiveness of a section
7 participants