Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshMap page section (v2, accordion) #3767

Merged
merged 62 commits into from
Feb 19, 2023
Merged

Conversation

Shivam-AfA
Copy link
Contributor

Description

This PR adds a new section in meshmap page (with accordion effect)

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Shivam-AfA and others added 30 commits January 27, 2023 15:07
Signed-off-by: Shivam-AfA <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: leecalcote <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
@l5io
Copy link
Contributor

l5io commented Feb 17, 2023

🚀 Preview for commit 6592c02 at: https://63ef8c9c437ff10af61c48a0--layer5.netlify.app

Signed-off-by: Lee Calcote <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
@l5io
Copy link
Contributor

l5io commented Feb 17, 2023

🚀 Preview for commit 2a4a51d at: https://63ef977b8b8cda11702b4423--layer5.netlify.app

@Shivam-AfA
Copy link
Contributor Author

@leecalcote we would want the all the SVGs for a section to be of the same width, else there'll be a lot of struggling with the CSS. Having the same width, the only things to worry about would be the top and bottom scaling.

The role-binding 1, 3 and 4 SVGs have same width. This can be taken care of while exporting from Figma. So either we can drop the role-binding 2 SVG or I can export all with the same width and use them.

@l5io
Copy link
Contributor

l5io commented Feb 17, 2023

🚀 Preview for commit 2bfd583 at: https://63efa1c46cb659006c2b34a4--layer5.netlify.app

Signed-off-by: leecalcote <[email protected]>
@l5io
Copy link
Contributor

l5io commented Feb 17, 2023

🚀 Preview for commit 40199e5 at: https://63eff9da38cdc30b24bb54ba--layer5.netlify.app

@Chadha93
Copy link
Member

@Shivam-AfA I think we should avoid containerizing the whole page.

@Chadha93
Copy link
Member

Lot's of commented code, make sure to remove it in the final commit.

@Shivam-AfA
Copy link
Contributor Author

Lot's of commented code, make sure to remove it in the final commit.

Yes. I'll remove it.

@Shivam-AfA
Copy link
Contributor Author

@Shivam-AfA I think we should avoid containerizing the whole page.

Like having separate containers for individual sections?

@l5io
Copy link
Contributor

l5io commented Feb 18, 2023

🚀 Preview for commit 5872e1b at: https://63f1565deeaea565c78d22a6--layer5.netlify.app

Signed-off-by: Shivam Sood <[email protected]>
@@ -75,6 +75,10 @@ const Meshmap = () => {
title: "Where all your design assets call home",
description: ""
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leecalcote Two points required here.

@Shivam-AfA
Copy link
Contributor Author

@leecalcote In the collaborate section also, we showcase 4 SVG transitions, but have 5 points listed.

@leecalcote
Copy link
Member

@leecalcote In the collaborate section also, we showcase 4 SVG transitions, but have 5 points listed.

Ok, thanks for pointing this out. No sweat. I'll update.

@l5io
Copy link
Contributor

l5io commented Feb 18, 2023

🚀 Preview for commit 635fb26 at: https://63f15e6b6938f5600455d5e9--layer5.netlify.app

Shivam-AfA and others added 2 commits February 19, 2023 05:07
Signed-off-by: Shivam Sood <[email protected]>
Signed-off-by: Lee Calcote <[email protected]>
@l5io
Copy link
Contributor

l5io commented Feb 18, 2023

🚀 Preview for commit 9adc545 at: https://63f1656039e955712e3f5812--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Feb 19, 2023

🚀 Preview for commit 691b4f3 at: https://63f169f0c155447157e6028d--layer5.netlify.app

@leecalcote leecalcote merged commit a048d5e into layer5io:master Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants