-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add newcomers page #1095
add newcomers page #1095
Conversation
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Deploy preview for layer5io ready! Built with commit b61f922 |
@Ruth-ikegah @tripathyprateek Please check it out and let me know if I need to change anything or add any more content. After that, I will change it from the draft and we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @navendu-pottekkat . I have taken a look, and mentioned some changes. Tagging @chandrashritii to take a look at this once and suggest changes if any.
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
@tripathyprateek The changes you mentioned have been made. I will mark the PR for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last small link change to polish up everything, and the rest looks good to me. Great work @navendu-pottekkat
Signed-off-by: Navendu Pottekkat <[email protected]>
@tripathyprateek I did not notice the broken link. Fixed it |
Signed-off-by: Navendu Pottekkat <[email protected]>
@Jashpatel1 @tripathyprateek I have fixed the links and removed the Hacktoberfest link. Please review and merge the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @navendu-pottekkat for going through all the hassle once again!
@navendu-pottekkat Great work here. All the things look perfect. Just a minor change in the Tutorials section. For screen widths below 400 px, it is not responsive. Can you look into it and fix it? If you wish to go for another PR for the change, no issues just tell me. Thanks for all the changes till now and also Thanks @tripathyprateek for your valuable feedback. |
@Jashpatel1 we should make a new issue for responsiveness, and get this page merged here😅 |
Cool, can you create the issue for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking to this for long @navendu-pottekkat . A lot of changes and a new page to the website. We will look forward if you plan to implement this in the layer5-ng website as well.
Yes, we should do that. I would be happy to work on it.
Yes we should make it a new issue and fix it. |
You are free to create the issue and work on it. |
Signed-off-by: Navendu Pottekkat [email protected]
Description
This is a draft PR and is subject to change after review.
This PR adds a Newcomers page under the Community dropdown.
The content is based on the Newcomer and Contributing Guides.
Added features:
This PR fixes #1064
Notes for Reviewers
Please check this out and let me know of any changes to be made.