Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add newcomers page #1095

Merged
merged 10 commits into from
Nov 9, 2020
Merged

add newcomers page #1095

merged 10 commits into from
Nov 9, 2020

Conversation

pottekkat
Copy link
Contributor

@pottekkat pottekkat commented Nov 7, 2020

Signed-off-by: Navendu Pottekkat [email protected]

Description

This is a draft PR and is subject to change after review.

This PR adds a Newcomers page under the Community dropdown.

The content is based on the Newcomer and Contributing Guides.

Added features:

  • Quick links to Layer5 pages and docs across the web added.
  • Instructions to newcomers added.
  • Hacktoberfest tutorials added.

This PR fixes #1064

Notes for Reviewers

Please check this out and let me know of any changes to be made.

  • Yes, I signed my commits.

Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
@netlify
Copy link

netlify bot commented Nov 7, 2020

Deploy preview for layer5io ready!

Built with commit b61f922

https://deploy-preview-1095--layer5io.netlify.app

@pottekkat
Copy link
Contributor Author

@Ruth-ikegah @tripathyprateek Please check it out and let me know if I need to change anything or add any more content.

After that, I will change it from the draft and we can merge.

Copy link
Contributor

@tripathyprateek tripathyprateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @navendu-pottekkat . I have taken a look, and mentioned some changes. Tagging @chandrashritii to take a look at this once and suggest changes if any.

Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
Signed-off-by: Navendu Pottekkat <[email protected]>
@pottekkat
Copy link
Contributor Author

@tripathyprateek The changes you mentioned have been made. I will mark the PR for review.

@pottekkat pottekkat marked this pull request as ready for review November 7, 2020 10:53
Copy link
Contributor

@tripathyprateek tripathyprateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last small link change to polish up everything, and the rest looks good to me. Great work @navendu-pottekkat

Signed-off-by: Navendu Pottekkat <[email protected]>
@pottekkat
Copy link
Contributor Author

@tripathyprateek I did not notice the broken link. Fixed it

tripathyprateek
tripathyprateek previously approved these changes Nov 7, 2020
collections/_pages/newcomers.html Outdated Show resolved Hide resolved
collections/_pages/newcomers.html Outdated Show resolved Hide resolved
collections/_pages/newcomers.html Outdated Show resolved Hide resolved
collections/_pages/newcomers.html Outdated Show resolved Hide resolved
_includes/newcomers/newcomers.html Outdated Show resolved Hide resolved
Signed-off-by: Navendu Pottekkat <[email protected]>
@pottekkat
Copy link
Contributor Author

@Jashpatel1 @tripathyprateek I have fixed the links and removed the Hacktoberfest link. Please review and merge the changes.

Copy link
Contributor

@tripathyprateek tripathyprateek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @navendu-pottekkat for going through all the hassle once again!

@Jashpatel1
Copy link
Member

@navendu-pottekkat Great work here. All the things look perfect. Just a minor change in the Tutorials section. For screen widths below 400 px, it is not responsive. Can you look into it and fix it? If you wish to go for another PR for the change, no issues just tell me. Thanks for all the changes till now and also Thanks @tripathyprateek for your valuable feedback.
image

@tripathyprateek
Copy link
Contributor

@navendu-pottekkat Great work here. All the things look perfect. Just a minor change in the Tutorials section. For screen widths below 400 px, it is not responsive. Can you look into it and fix it? If you wish to go for another PR for the change, no issues just tell me. Thanks for all the changes till now and also Thanks @tripathyprateek for your valuable feedback.
image

@Jashpatel1 we should make a new issue for responsiveness, and get this page merged here😅

@Jashpatel1
Copy link
Member

@navendu-pottekkat Great work here. All the things look perfect. Just a minor change in the Tutorials section. For screen widths below 400 px, it is not responsive. Can you look into it and fix it? If you wish to go for another PR for the change, no issues just tell me. Thanks for all the changes till now and also Thanks @tripathyprateek for your valuable feedback.

@Jashpatel1 we should make a new issue for responsiveness, and get this page merged here😅

Cool, can you create the issue for it?

Copy link
Member

@Jashpatel1 Jashpatel1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sticking to this for long @navendu-pottekkat . A lot of changes and a new page to the website. We will look forward if you plan to implement this in the layer5-ng website as well.

@Jashpatel1 Jashpatel1 merged commit 0d74274 into layer5io:master Nov 9, 2020
@pottekkat
Copy link
Contributor Author

Thanks for sticking to this for long @navendu-pottekkat . A lot of changes and a new page to the website. We will look forward if you plan to implement this in the layer5-ng website as well.

Yes, we should do that. I would be happy to work on it.

@Jashpatel1 we should make a new issue for responsiveness, and get this page merged heresweat_smile

Yes we should make it a new issue and fix it.

@Jashpatel1
Copy link
Member

Thanks for sticking to this for long @navendu-pottekkat . A lot of changes and a new page to the website. We will look forward if you plan to implement this in the layer5-ng website as well.

Yes, we should do that. I would be happy to work on it.

@Jashpatel1 we should make a new issue for responsiveness, and get this page merged heresweat_smile

Yes we should make it a new issue and fix it.

You are free to create the issue and work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Layer5] Add a newcomers page to the site
3 participants