Desktop: Fixes #9919: Command palette not showing note title #9961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@laurent22 I made the modification that you suggested. I also added a comment explaining the behavior of SearchEngine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9919
Description
The search engine used in
GoToAnythingis normalizing the content of the notes to help index and search content, but in this process, the original title of the note is never preserved. I'm modifyingGoToAnythingaka command palette to load the original title to override the search engine result.After fix:
Testing
1 - Create a note with a title with any special character or with upper case letters (e.g: "Uma Nota ãóç")
2 - Open the command palette and type the note title
3 - It should render the original title in the results and not a normalized version like it used (characters were "normalized", all lower case)