Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Cli: Migrate most commands to TypeScript #9552

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Dec 18, 2023

Summary

The main goal of this pull request is to make implementing #9465 easier (which, at present, makes the options parameter required for item deletion).

Testing

  • Manual testing of the changed commands
    • apidoc
      • Runs and renders Types that make sense in the "Properties" tables.
    • attach
      • Can attach a file to the current note
    • cat
    • config
      • Can change sync.target
      • : config lists all current config values.
      • Can change the editor setting by importing settings from a file
      • Note: Redirecting output from yarn start config --export to a file produces an empty file (to stdout works fine). This seems to be an existing issue.
    • cp
      • cp <note name> duplicates the note
      • cp <note name> <notebook name> creates a copy of the note in <notebook name>.
    • done
      • Marks given note as done.
    • dump
      • Outputs JSON
    • edit
    • exit
    • export-sync-status
      • Exports a table with item IDs, updated time, etc.
    • export
      • Can export to md to a specific path
    • geoloc
    • help
      • Can see a list of commands
      • Can see help for a specific command (ls, use, export-sync-status, ...).
    • import
      • Can import from a markdown directory
      • Can import from an ENEX file (packages/app-cli/tests/enex_to_html/checkbox-list.enex)
        • Shows an error when import fails and shows progress (packages/app-cli/tests/enex_to_md/ImportTestCorrupt.enex)
    • ls
      • Can list all notebooks
      • Can list all notes in the current notebook
      • Can list the first note in the current notebook
    • mv
      • Can move a note to a parent notebook
    • ren
      • Can rename note
      • Can rename notebook
    • rmbook
    • rmnote
    • set
      • Can change title with :set notetitle title "new title"
    • use
    • version

@personalizedrefrigerator personalizedrefrigerator changed the title Cli: Migrate most commands to TypeScript Chore: Cli: Migrate most commands to TypeScript Dec 18, 2023
@laurent22 laurent22 merged commit 4ec2fb2 into laurent22:dev Dec 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants