Mobile: CodeMirror: Tests: Ensure full document is parsed, don't rely on timeout #7405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 4, 2022
laurent22
reviewed
Dec 7, 2022
| const timeout = 100; // ms | ||
| ensureSyntaxTree(editorState, editorState.doc.length, timeout); | ||
| } | ||
| while (!syntaxTreeAvailable(editorState)); |
There was a problem hiding this comment.
Could you add a guard against infinite loops please? Because if it happens it will be hard to find where. Maybe count the loops and after a thousand or something throw an exception.
There was a problem hiding this comment.
It might make more sense to just have a large timeout (e.g. 3 seconds), then throw if !syntaxTreeAvailable — this should be equivalent to the above loop with a guard.
There was a problem hiding this comment.
Indeed that's a better solution, thanks for the update!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
forceParsingandensureSyntaxTreebeing large enough, parsing is attempted until the syntax tree is available.