PDF Viewer: Full screen viewer #6821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent22
reviewed
Sep 5, 2022
|
Thanks for the update, the queue code is simpler and clearer now, so let's merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to bring the full-screen pdf viewer to desktop.
The full-screen viewer is rendered in an iframe similar to mini-viewer in a full-screen dialog modal.
To access the viewer, click on the pdf link or double click on any page in the embedded viewer to open that particular page.
Opening the file in an external viewer is still accessible from the full-screen viewer's menu.
The page rendering logic is revamped and a rendering queue is used to avoid certain bugs of simultaneous rendering. It also makes the text selectable with copy option on right click.
Demo
full-screen-demo1.mov