Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Add libvips dependency for Apple Silicon build instructions #5966

Conversation

nickhobbs94
Copy link
Contributor

Thanks to this thread for solving my issue. I figured this should be in the build instructions.

@tessus tessus changed the title All: Add libvips dependency for Apple Silicon build instructions Doc: Add libvips dependency for Apple Silicon build instructions Jan 6, 2022
@tessus
Copy link
Collaborator

tessus commented Jan 6, 2022

Isn't the module installing the library? e.g. like 7zip-bin-linux and sqlite3, ...

@tessus tessus added the documentation Documentation, web site, README label Jan 6, 2022
@nickhobbs94
Copy link
Contributor Author

nickhobbs94 commented Jan 7, 2022

Looks like a later version of sharp is needed if we want it to fetch the prebuilt binaries.

Prebuilt sharp and libvips binaries are provided for macOS on ARM64 from sharp v0.29.0.
Prebuilt libvips binaries were provided for macOS on ARM64 from sharp v0.28.0.

Source: https://sharp.pixelplumbing.com/install

There's a couple versions listed in the yarn.lock file but no later than v0.26.3.

@laurent22
Copy link
Owner

Not sure we should add this for now, because then we'll have to remember to remove it when we upgrade Sharp. Or should we upgrade sharp now? Would there be any breaking changes?

@laurent22
Copy link
Owner

Ok let's merge, thanks for the info @nickhobbs94.

@laurent22 laurent22 merged commit 89184a3 into laurent22:dev Jan 9, 2022
@BalanaguYashwanth
Copy link

hey i am getting this issue when running desktop app in mac with Apple silicon m1

Uncaught Error: Cannot find module '/Users/yashwanth/other-projects/open-source/joplin/packages/app-desktop/node_modules/sqlite3/lib/binding/napi-v3-darwin-arm64/node_sqlite3.node'

Any solution ?

@BalanaguYashwanth
Copy link

I guess found solution - TryGhost/node-sqlite3#1538 (comment)

If any alternative solutions are there please comment it below👇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation, web site, README
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants