Desktop: Implements a patch for multimd #5815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug in the multimarkdown-table library such that it isn't mapping tokens to line numbers properly and isn't correctly setting the markdown "level" (depth) of a token. This patch was originally submitted for review upstream, but as of now has not been accepted.
ref: redbug312/markdown-it-multimd-table#42
I haven't heard back yet on the upstream patch, but it's only been a day so I'm not too concerned. I've prepared this PR in case you want to get the fix into Joplin sooner, but I think it's worth waiting until at least the weekend.
There were 2 more (less critical) bugs associated with #5808, but they're being tracked separately. #5811 and redbug312/markdown-it-multimd-table#41.