[mobile] webview: Enable debugging on browser.

[ishammahajan]

Enables debugging for the android plugin which
react-native-webview uses. This method is mentioned in their guide
for the same.
https://github.com/react-native-community/react-native-webview/blob/master/docs/Debugging.md

Unfortunately the call requires API version >= 19 (After Kitkat),
which is fine because our testing may occur at a higher API level.

[ishammahajan]

I used this in order to debug an issue. I think it'll be helpful if everyone can benefit from it!

Also, @PackElend label me -- if this qualifies as a valid PR! :)

[laurent22]

This is useful but we can't enable this in production. Best would be to leave it commented out by default, and people can uncomment it if they need. Also in the comments, please add a link to the rn-webview doc.

[ishammahajan]

We can also add a BuildConfig.DEBUG flag to the if condition, which is what I have done with the new push.

[laurent22]

Sorry but now you've converted the whole file to a different indentation (and to space, while we use tabs). Please only change what you need to change and don't modify the rest of the file.

[ishammahajan]

Ah. Sorry. I've changed this based on Android Studio's auto formatter. I think this is a good way to go, because then we can enforce a consistent style on the file. The file currently doesn't have any consistent style, where some parts use tabs and some use spaces.

If this isn't acceptable, I think it's okay to merge only the first commit :) (I'm not near a computer at the moment, can't push an updated version)

[PackElend]

I've changed this based on Android Studio's auto formatter. I think this is a good way to go, because then we can enforce a consistent style on the file. The file currently doesn't have any consistent style, where some parts use tabs and some use spaces.

that is good point but should be discussed in the forum

[ishammahajan]

Affirmative. I'll create a topic once I reach home.

…

On Thu, 27 Feb, 2020, 3:39 pm PackElend, ***@***.***> wrote: I've changed this based on Android Studio's auto formatter. I think this is a good way to go, because then we can enforce a consistent style on the file. The file currently doesn't have any consistent style, where some parts use tabs and some use spaces. that is good point but should be discussed in the forum — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2586?email_source=notifications&email_token=AH5JPGB5MHYOQFLSOESMXKTRE6GOBA5CNFSM4K35TCGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDYB7I#issuecomment-591888637>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AH5JPGFLO6RJ6L235H7STTLRE6GOBANCNFSM4K35TCGA> .

[ishammahajan]

Ping. Kind reminder :)

[laurent22]

Looks good, thanks for the update @ishammahajan!