Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Fix pasting PNG and JPEG images from the clipboard #10777

Merged

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request fixes a regression that caused Joplin to fail to paste image files on Android. (Most testing for #10751 was done on iOS.)

Testing plan

Regression testing

This pull request has been tested by:

  1. Opening edit mode on a note.
  2. Attaching a PNG or JPEG image.
    • JPEG on iOS, PNG on Android

This has been tested successfully on an iOS 17.4 simulator and an Android 13 device.

Pasting images

On Android 13:

  1. Copy a small PNG image from Chrome.
  2. Paste the image into Joplin's note editor.
  3. Verify that a resource is added.
  4. Copy a large PNG image from Chrome.
  5. Paste the image into Joplin's note editor.
  6. Choose "yes" to decrease the image size.
  7. Verify that a resource is added.
  8. Switch to the note viewer. Verify that both images render.

This commit fixes a regression related to attaching JPEG and PNG images
on Android.
@laurent22 laurent22 merged commit 77b74da into laurent22:dev Jul 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants