Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #10679: Fix incorrect text rendering on MacOS by changing the default font to Avenir Next #10686

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jul 5, 2024

Summary

This is one possible fix for #10679.

See this discussion post for a confirmation that using "Avenir Next" seems to fix the issue.

Important

I am unable to reproduce this locally (MacOS Sonoma 14.5, Intel, all plugins disabled). It's unclear how many users this affects.

Comparison between Avenir and Avenir Next

screenshot: Avenir Next bold is slightly bolder

Comparison to other possible fixes

Benefits:

  • Relatively simple fix
  • We have confirmation that this, or a similar change, fixes the issue from a user on the Joplin Forum.

Drawbacks:

  • Affects all platforms that have Avenir Next installed (MacOS, iOS, and MacOS viewing published notes).
  • Somewhat changes the appearance of rendered notes. Has a noticeable effect on bold text (screenshots to be attached).

Possible alternatives:

  • Try upgrading Electron.
  • Use Montserrat as the default font and bundle it. Montserrat seems similar to Avenir and is licensed under the Open Font License.
    • I don't think we can bundle Avenir, due to licensing restrictions.

Testing

  1. Start Joplin.
  2. Open a note.
  3. Verify that the note renders in a sans-serif-style font.
  4. Open the Rich Text editor.
  5. Verify that the note is still rendered in a sans-serif-style font.

This is one possible fix for laurent22#10679.

Benefits:
- Relatively simple fix
- We have confirmation that this, or a similar change, fixes the issue
  from a user on the Joplin Forum.

Drawbacks:
- Affects all platforms.
- Somewhat changes the appearance of rendered notes. Has a noticeable effect
  on bold text (screenshots to be attached).

Possible alternatives:
- Try upgrading Electron.
   - There are a [few bugs](https://issues.chromium.org/issues?q=avenir) in the Chromium issue tracker that might be
     related:
     - https://issues.chromium.org/issues/328279705 (tagged as a
       duplicate of a WONTFIX(infeasible) bug), different repro
       conditions.
- Use Montserrat as the default font and bundle it. Montserrat seems
  similar to Avenir and is licensed under the
  [Open Font License](https://fonts.google.com/specimen/Montserrat).
  - I don't think we can bundle Avenir, due to licensing.
@laurent22 laurent22 merged commit a3e0410 into laurent22:release-3.0 Jul 5, 2024
10 checks passed
@laurent22
Copy link
Owner

Thanks for the fix, let's merge this for now since the app is unusable for some users and maybe later we can investigate if there's a better fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants