Chore: Fix CI #10646
Merged
Chore: Fix CI #10646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
personalizedrefrigerator
referenced
this pull request
Jun 20, 2024
Comment on lines
-6
to
+7
| import dayjs = require('dayjs'); | ||
| import dayJsRelativeTime = require('dayjs/plugin/relativeTime'); | ||
| import * as dayjs from 'dayjs'; | ||
| import * as dayJsRelativeTime from 'dayjs/plugin/relativeTime'; |
There was a problem hiding this comment.
The import = require import style was failing here:
error ../utils/time.ts: /home/runner/work/joplin/joplin/packages/utils/time.ts: `import dayjs = require('dayjs')` is not supported by @babel/plugin-transform-typescript
Please consider using `import dayjs from 'dayjs';` alongside Typescript's --allowSyntheticDefaultImports option.
SyntaxError: /home/runner/work/joplin/joplin/packages/utils/time.ts: `import dayjs = require('dayjs')` is not supported by @babel/plugin-transform-typescript
Please consider using `import dayjs from 'dayjs';` alongside Typescript's --allowSyntheticDefaultImports option.
4 | // -----------------------------------------------------------------------------------------------
5 |
> 6 | import dayjs = require('dayjs');
4 | // -----------------------------------------------------------------------------------------------
5 |
> 6 | import dayjs = require('dayjs');
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
7 | import dayJsRelativeTime = require('dayjs/plugin/relativeTime');
8 |
9 | const supportedLocales: Record<string, unknown> = {.
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
7 | import dayJsRelativeTime = require('dayjs/plugin/relativeTime');
8 |
9 | const supportedLocales: Record<string, unknown> = {
at File.buildCodeFrameError (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@react-native/metro-babel-transformer/node_modules/@babel/core/lib/transformation/file/file.js:205:12)
at NodePath.buildCodeFrameError (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/path/index.js:105:21)
at PluginPass.TSImportEqualsDeclaration (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/plugin-transform-typescript/lib/index.js:397:22)
at newFn (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/visitors.js:153:14)
at NodePath._call (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/path/context.js:46:20)
at NodePath.call (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/path/context.js:36:17)
at NodePath.visit (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/path/context.js:82:31)
at TraversalContext.visitQueue (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/context.js:86:16)
at TraversalContext.visitMultiple (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/context.js:61:17)
at TraversalContext.visit (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/context.js:107:19)
at traverseNode (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/traverse-node.js:18:17)
at NodePath.visit (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/path/context.js:88:52)
at TraversalContext.visitQueue (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/context.js:86:16)
at TraversalContext.visitSingle (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/context.js:65:19)
at TraversalContext.visit (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/context.js:109:19)
at traverseNode (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/traverse-node.js:18:17)
at traverse (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@babel/traverse/lib/index.js:49:34)
at transformFile (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@react-native/metro-babel-transformer/node_modules/@babel/core/lib/transformation/index.js:81:29)
at transformFile.next (<anonymous>)
at run (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@react-native/metro-babel-transformer/node_modules/@babel/core/lib/transformation/index.js:24:12)
at run.next (<anonymous>)
at /home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@react-native/metro-babel-transformer/node_modules/@babel/core/lib/transform-ast.js:23:41
at Generator.next (<anonymous>)
at evaluateSync (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/gensync/index.js:251:28)
at sync (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/gensync/index.js:89:14)
at stopHiding - secret - don't use this - v1 (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@react-native/metro-babel-transformer/node_modules/@babel/core/lib/errors/rewrite-stack-trace.js:46:12)
at transformFromAstSync (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@react-native/metro-babel-transformer/node_modules/@babel/core/lib/transform-ast.js:44:83)
at Object.transform (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/@react-native/metro-babel-transformer/src/index.js:217:7)
at transformJSWithBabel (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/metro-transform-worker/src/index.js:285:45)
at Object.transform (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/metro-transform-worker/src/index.js:408:18)
at transformFile (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/metro/src/DeltaBundler/Worker.flow.js:54:36)
at Object.transform (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/metro/src/DeltaBundler/Worker.flow.js:30:10)
at execFunction (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/jest-worker/build/workers/processChild.js:149:17)
at execHelper (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/jest-worker/build/workers/processChild.js:137:5)
at execMethod (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/jest-worker/build/workers/processChild.js:140:5)
at process.messageListener (/home/runner/work/joplin/joplin/packages/app-mobile/node_modules/jest-worker/build/workers/processChild.js:44:7)
at process.emit (node:events:517:28)
at emit (node:internal/child_process:944:14)
> Task :app:createBundleReleaseJsAndAssets FAILED
| if (!d.isValid()) return 'Invalid Date'; | ||
| if (!d.isValid()) return 'Invalid date'; |
There was a problem hiding this comment.
Related to this test failure:
➤ YN0000: [@joplin/lib]: FAIL services/noteList/renderViewProps.test.js
➤ YN0000: [@joplin/lib]: ● renderViewProps › should handle invalid view props
➤ YN0000: [@joplin/lib]:
➤ YN0000: [@joplin/lib]: expect(received).toEqual(expected) // deep equality
➤ YN0000: [@joplin/lib]:
➤ YN0000: [@joplin/lib]: - Expected - 1
➤ YN0000: [@joplin/lib]: + Received + 1
➤ YN0000: [@joplin/lib]:
➤ YN0000: [@joplin/lib]: Object {
➤ YN0000: [@joplin/lib]: "note": Object {
➤ YN0000: [@joplin/lib]: "tags": 123,
➤ YN0000: [@joplin/lib]: - "user_updated_time": "Invalid date",
➤ YN0000: [@joplin/lib]: + "user_updated_time": "Invalid Date",
➤ YN0000: [@joplin/lib]: },
➤ YN0000: [@joplin/lib]: }
➤ YN0000: [@joplin/lib]:
➤ YN0000: [@joplin/lib]: 50 | Logger.globalLogger.enabled = true;
➤ YN0000: [@joplin/lib]: 51 |
➤ YN0000: [@joplin/lib]: > 52 | expect(view).toEqual({
➤ YN0000: [@joplin/lib]: | ^
➤ YN0000: [@joplin/lib]: 53 | note: {
➤ YN0000: [@joplin/lib]: 54 | user_updated_time: 'Invalid date',
➤ YN0000: [@joplin/lib]: 55 | tags: 123,
➤ YN0000: [@joplin/lib]:
➤ YN0000: [@joplin/lib]: at toEqual (services/noteList/renderViewProps.test.ts:52:16)
➤ YN0000: [@joplin/lib]: at fulfilled (services/noteList/renderViewProps.test.js:12:24)
➤ YN0000: [@joplin/lib]:
|
Thanks for fixing all this! Strange that the imports were working fine for me but not on CI, and it seems other people too have this problem. Somehow the same syntax works on Joplin Server |
fabiogvdneto
pushed a commit
to fabiogvdneto/joplin
that referenced
this pull request
Jun 21, 2024
pedr
pushed a commit
to pedr/joplin
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the review comments below for an explanation of the changes made in this PR.