Chore: Increase strength of Setting
s types
#10605
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request demonstrates a way to strengthen types returned by
Setting.value('some-key-here')
andappState.settings['some-key-here']
.Examples:
Setting.value
Return type of
Setting.value('editor.usePlainText')
:any
boolean
Return type of
Setting.value('folders.sortOrder.field')
:any
string
Return type of
Setting.value('someCustomSetting')
:any
any
Example:
Setting.setValue
Setting.setValue('showMenuBar', 123456);
:Argument of type 'number' is not assignable to parameter of type 'boolean'
.Testing plan