Chore: Increase strength of Settings types
#10605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+63
to
+64
| // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Partial refactor of old code before rule was applied | ||
| Setting.setValue('notes.perFieldReverse', { ...perFieldReverse } as any); |
There was a problem hiding this comment.
To-do -- better type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request demonstrates a way to strengthen types returned by
Setting.value('some-key-here')andappState.settings['some-key-here'].Examples:
Setting.valueReturn type of
Setting.value('editor.usePlainText'):anybooleanReturn type of
Setting.value('folders.sortOrder.field'):anystringReturn type of
Setting.value('someCustomSetting'):anyanyExample:
Setting.setValueSetting.setValue('showMenuBar', 123456);:Argument of type 'number' is not assignable to parameter of type 'boolean'.Testing plan