Desktop, Mobile: Start synchronisation just after login is complete #10574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent22
reviewed
Jun 12, 2024
| @@ -90,6 +91,7 @@ const JoplinCloudScreenComponent = (props: Props) => { | |||
| if (response && response.success) { | |||
| dispatch({ type: 'COMPLETED' }); | |||
| clearInterval(interval); | |||
| void CommandService.instance().execute('synchronize'); | |||
There was a problem hiding this comment.
Does it definitely work on mobile too? Since this command contains reducer actions that don't exist in mobile, and it's also quite new the support for commands on mobile
There was a problem hiding this comment.
Yes, I tested it and it was working. I will double-check if any errors are happening that I didn't see.
There was a problem hiding this comment.
I couldn't find any errors. I could change the line to:
void reg.scheduleSync(0);
Since ultimately it is what is happening when executing the command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's pretty straight forward, calling the command
synchronizeafter login is confirmed