Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Rich Text Editor: Allow toggling bulleted and numbered lists from the command palette #10559

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jun 10, 2024

Summary

This pull request maps Joplin's list commands (textBulletedList and textNumberedList) to TinyMCE commands. This is related to #10218.

To fully fix #10218, it would be necessary to register keyboard shortcuts with TinyMCE for existing Joplin commands, similar to what is done for CodeMirror. It seems likely that this will require the TinyMCE shortcuts API — trying to handle these shortcuts in onKeyDown causes conflicts with the TinyMCE built-in shortcuts (see this branch for a broken implementation).

Testing plan

  1. Open a note in the Rich Text Editor.
  2. Select text.
  3. Open the command palette and run textBulletedList.
  4. Verify that the selected text has been converted to a bulleted list.
  5. Repeat steps 3-4 for textNumberedList.

This has been tested successfully on Ubuntu 24.04.

@laurent22 laurent22 merged commit 97d15bb into laurent22:dev Jun 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create bulleted list hotkey not working in rich text editor
2 participants