Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fix "new notebook" shown in context menu when right-clicking on the "Tags" header #10378

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Apr 26, 2024

Summary

This pull request fixes a regression caused by #10331. The "new notebook" context menu item was incorrectly shown when right-clicking on the "TAGS" header.

Testing plan

  1. Right-click on the "TAGS" header and verify that there is no context menu.
  2. Right-click on the "NOTEBOOKS" header and verify that the context menu has one item: "New notebook".
  3. Create a new notebook with the context menu item.

This has been tested successfully on MacOS 14.4.1.

@personalizedrefrigerator personalizedrefrigerator changed the title Desktop: Fix context menu for tags header allows creating new notebooks Desktop: Fix "new notebook" shown in context menu when right-clicking on the "Tags" header Apr 26, 2024
@laurent22 laurent22 merged commit 09216b8 into laurent22:dev Apr 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants