Desktop, Mobile: Display a message when Joplin Cloud user don't have access to email to note feature #10322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Pedro, that looks good and leaving the button in mobile is fine too. For the text "Your account doesn't have access to this feature" on mobile, could you please make it darker, maybe same colour as the "Email to note" label? |
Is that all right? |
|
That looks good now, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display a message to the user indicating that the feature is currently disabled for that account.
In the mobile implementation I decided to keep the button visible but just disable it because the feature description is associated with the button in the code. Would it be better to hide the button and keep the feature description visible?
I'm open to suggestions on how we could present this.
Screenshots Desktop
Screenshots Mobile