Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "Copy code" button on code blocks #2383

Open
laurent22 opened this issue Jan 27, 2020 · 38 comments
Open

Add a "Copy code" button on code blocks #2383

laurent22 opened this issue Jan 27, 2020 · 38 comments
Labels
backlog We'll get to it... eventually... desktop All desktop platforms mobile All mobile platforms

Comments

@laurent22
Copy link
Owner

laurent22 commented Jan 27, 2020 •
edited
Loading

When a code block is displayed, add a "Copy" button in the top-right hand corner. Clicking on it should copy the code to the clipboard. That button should only be displayed when the user moves the mouse over the code block.

Note that this feature should be added to the joplin-renderer

Platforms

  • Desktop
  • Mobile

image
@laurent22 laurent22 added good first issue mobile All mobile platforms desktop All desktop platforms labels Jan 27, 2020
@Runo-saduwa
Copy link
Contributor

Please i will love to try to implement this, can this issue be assigned to me?, and if theres anyone more familier with the codebase, i will love to work together

@bedwardly-down
Copy link
Contributor

@Runo-saduwa, I'm currently working on my own assignment here involving changes in the user interface and whatnot. I spent all night digging through a large chunk of the rendering and electron code and am getting fairly familiar with it, especially after the devs here started separating some of the dialog code. One very cool thing about the code here: most of the functions and class names are sensible and describe exactly what their overall function is for the most part, and those that don't make a whole lot of sense outright, it's pretty easy to figure out what they do by searching for where they're used in the code.

@laurent22
Copy link
Owner Author

@Runo-saduwa, at this point we only assign up to one issue per person.

@Runo-saduwa
Copy link
Contributor

Runo-saduwa commented Jan 28, 2020 •
edited
Loading

alright, thank you

@bedwardly-down
Copy link
Contributor

@laurent22 that is very reasonable. Thank you

@Runo-saduwa Runo-saduwa mentioned this issue Jan 29, 2020
Closed
@Runo-saduwa
Copy link
Contributor

Runo-saduwa commented Jan 29, 2020 •
edited
Loading

@laurent22 , i'm trying to give this a shot, so if i understand you correctly, this is going to be implemented in this repo joplin-renderer

@laurent22
Copy link
Owner Author

Yes indeed. Hmm now that the renderer is in a different repo it's not very easy to with with actually.

I'll see if I can think of something to make it easier, maybe by moving it back to this repo.

@Runo-saduwa
Copy link
Contributor

Well, ive pulled the latest changes, i've been staring at the code for an hour now and i dont know where to start from, Lol............... can you kindly guide me through where to start from

@bedwardly-down
Copy link
Contributor

bedwardly-down commented Feb 1, 2020 •
edited
Loading

@Runo-saduwa it looks like NoteRevisonViewer.jsx and NoteText.jsx under ElectronClient/app/gui would be a good place to start. A lot of the editor rendering code is there. Then follow it where it takes you. The way each part of the app is linked is very sensible and logical.

@Runo-saduwa Runo-saduwa mentioned this issue Feb 8, 2020
Closed
@rheo-chiti
Copy link

Is this issue fixed for mobile yet,if not can I work upon this ?

@Runo-saduwa
Copy link
Contributor

Runo-saduwa commented Feb 9, 2020 via email

@HirenMadhu
Copy link

Is this issue still open?
If yes, then can I work on it?

@raghavg27
Copy link

Anyone working on this?

@tessus
Copy link
Collaborator

tessus commented Mar 12, 2020

If there's no PR open, say you'll work on it and create a PR when ready.

We had so many people who said they'll work on something, but then nothing happened.
So, if you take an issue, please keep us apprised of the status.

@Rishabh-malhotraa

This comment has been minimized.

Sign in to view
@flozender
Copy link

I would like to work on this, please.

@Rishabh-malhotraa
Copy link
Contributor

I would like to work on this, please.

Yes, @flozender go ahead.

@Rishabh-malhotraa
Copy link
Contributor

@laurent22 I have a question about the way to solve this, can we just not add the button HTML syntax here rather than writing the markdown plugin for it

copy code

@kowalskidev
Copy link
Contributor

I'm working on it 👍

@Rishabh-malhotraa
Copy link
Contributor

I'm working on it 👍

please don't I'm done with this PR

@Rishabh-malhotraa Rishabh-malhotraa mentioned this issue Apr 11, 2020
Closed
@wjrivera
Copy link

wjrivera commented Jul 4, 2020

Was this feature implemented in Pull Request 3024 ?

@tessus
Copy link
Collaborator

tessus commented Jul 4, 2020

No.

@wjrivera
Copy link

Is anyone assigned to this atm?

@tessus
Copy link
Collaborator

tessus commented Sep 21, 2020

No, there were PRs at one point, but they were not merged. More info in #2426 and #3024

@Ash0311
Copy link

Ash0311 commented Feb 9, 2021

when will this be released ?

@tessus
Copy link
Collaborator

tessus commented Feb 9, 2021

It won't, unless somebody picks up the PR a finishes it.

@ArenaGrenade
Copy link

Hey @tessus I am looking at the PRs made for this issue #2426 seems quite complete - except for the updates it needs on mobile. And #3024 seems to be a incomplete one and possibly stale for a long time.

What is the exact part of the feature that is yet to be done here? Is it that we need to make sure this works on mobile devices?

@laurent22 laurent22 added backlog We'll get to it... eventually... and removed good first issue labels Mar 13, 2021
@laurent22
Copy link
Owner Author

This was incorrectly labelled as a "good first issue" but it's actually difficult to add this properly. And last year pull requests cannot be used a starting point as they weren't following the right approach.

@ArenaGrenade
Copy link

Ah! Sure.

@Ash0311
Copy link

Ash0311 commented Jun 12, 2021 •
edited
Loading

Please add this soon as this is needed !

@ArenaGrenade
Copy link

As of now what's the status of this issue? Is the button implemented anywhere - desktop / mobile?

@tessus tessus mentioned this issue Sep 30, 2021
Closed
@riekusr
Copy link

riekusr commented Oct 30, 2021

Would love to have this function as well

@RestlessRabbits
Copy link

Is there someone working on this?
I would also love to see this function :)

@kar0v
Copy link

kar0v commented Dec 17, 2022

I'm also missing this feature in joplin. Commenting for visibility.

@ckza
Copy link

ckza commented Dec 21, 2022

Also commenting for visibility. Currently doing quite a bit of code and would love to have a nicer code block, with the copy button, to streamline my workflow. Otherwise I need to start using another note taking app and I would prefer to stick to Joplin.

@polytect
Copy link

Hi guys!

Can this feature be added to Joplin? It would attract even more users.

@Waldorf3
Copy link

Adding my support for this feature

@mntky
Copy link

mntky commented Jul 7, 2023

I am using this plugin.
This plugin is working fine:)

https://github.com/LightAPIs/joplin-copy-code-blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog We'll get to it... eventually... desktop All desktop platforms mobile All mobile platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DESKTOP: Adding copy to clipboard button for code block