Skip to content

Commit

Permalink
[FLINK-10772][release] Fix create_binary_release.sh
Browse files Browse the repository at this point in the history
Remove the unnecessary call to change_scala_version.sh and remove the
-Dmaven.test.skip=true property. The latter is necessary because this
property suppresses the compilation and packaging of test classes. It,
however, does not suppress the resolution of test dependencies which
will then fail to compile because test dependencies have not been built.

This commit also removes the redundant call to build
flink-shaded/hadoop/flink-shaded-hadoop2-uber which is a dependency
of flink-dist anyway.
  • Loading branch information
tillrohrmann committed Nov 5, 2018
1 parent 413a771 commit 742658c
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions tools/releasing/create_binary_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,7 @@ make_binary_release() {
fi

# enable release profile here (to check for the maven version)
tools/change-scala-version.sh ${SCALA_VERSION}
$MVN clean package $FLAGS -Prelease -pl flink-shaded-hadoop/flink-shaded-hadoop2-uber,flink-dist -am -Dgpg.skip -Dcheckstyle.skip=true -DskipTests -Dmaven.test.skip=true
$MVN clean package $FLAGS -Prelease -pl flink-dist -am -Dgpg.skip -Dcheckstyle.skip=true -DskipTests

cd flink-dist/target/flink-*-bin/
tar czf "${dir_name}.tgz" flink-*
Expand Down

0 comments on commit 742658c

Please sign in to comment.