Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc about \symXX and \mathXX #415

Closed
wants to merge 2 commits into from
Closed

Doc about \symXX and \mathXX #415

wants to merge 2 commits into from

Conversation

eg9
Copy link
Contributor

@eg9 eg9 commented Oct 15, 2017

First attempt to clarify the differences

First attempt to clarify the differences
Description
@wspr
Copy link
Collaborator

wspr commented Oct 16, 2017

Thank you, this is fantastic!

Only one problem — since you changed the readme that means if I accept this pull request my readme will be replaced by your readme :) To be honest I'm not sure the best way to fix this!! I could always accept the pull request and then revert the second commit I suppose... let me know if that would be easiest for you!

@josephwright
Copy link
Member

@wspr Two approaches: @eg9 could remove the commit from his branch and force-push so the PR is 'right', or you could pull the changes into a local branch at your end then cherry-pick the 'good' commit.

@wspr
Copy link
Collaborator

wspr commented Oct 16, 2017

@josephwright — ah, the "command line instructions" were a great help :) Done!

@wspr wspr closed this Oct 16, 2017
@wspr
Copy link
Collaborator

wspr commented Oct 16, 2017

(Cherry-picked the commit into ac222c9 into branch "working")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants