Simplify subscript-peeking, avoid expl3 internals (fixes #395) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh dear, of course this was all my fault! This code comes from early expl3 days and I'd forgotten it was still using peeking internals :( I'm very sorry to have taken up your time with this — thank you for taking this on. |
|
No problem! :) Thanks for merging so quickly. |
|
I just realised I hadn’t pushed last time I bumped the version, so this will turn out a bit ugly when I have to merge later. Too many things on the go at once I’m afraid. Thanks again.
|
|
Anything I can do to help? E.g. rebasing the pull-request? (I'd rather not reverse the expl3 improvements.) |
|
No worries — apologies my message was a bit cryptic; just merging the code now. I don't have a good merging tool on my laptop and always seem to mess it up :) |
|
Ok, thanks. I was worried this would be a blocker for updating to CTAN. |
|
Nope, I’ll send an update tonight.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unicode-mathabused\__peek_true:wand other internals ofexpl3rather than just copying their definitions. When I changed implementation details inl3token.dtxthis broke. Now fixed by avoiding any use of internals (at least in the functions I changed).As a separate change I made the property lists
\g_@@_subs_propand\g_@@_supers_prop's keys be simply the characters themselves rather than their meaning: this needlessly forbade characters whose catcode had been changed for whatever reason.