Support for XeTeX 0.9998 and other bug fixes #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already use other new features without checking, so the code is already broken for older LuaTeX versions.
Now that \XeTeXmathaccent accepts the same keywords as LuaTeX's \Umathaccent.
Now that XeTeX can handle fixed and bottom accents, there is no need for different code paths.
No more hacks, they can now be handled as regular accents just like in LuaTeX.
They were, more or less, duplicating \um_wide_top/bottom_accent:Nnn, so we now just use the later
We will need yet another one for fixed bottom accents, so just make the macro as general as the underlying primitive.
It is a wide under accent
It is too small resulting in LuaTeX picking smaller glyph than it should, XeTeX has some sanity check to get around such thing but I don’t think it is appropriate to hardcode this in LuaTeX engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request include al the changes in the previous one that I just cancelled (text below for reference), plus some bug fixes and features from the issue tracker.
What remains now is how to handle old engines, my own preference it to check for XeTeX ≥ 0.9998 and LuaTeX ≥ 0.70 and print an error message otherwise, supporting older engines is not worth the effort and complication it brings.
BTW, if you need Linux or Mac binaries of the new engine version for testing, let me know and I'll send what I've (of course, you can always built it your self).