Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #1407 #1408

Merged
merged 3 commits into from
Jul 13, 2024
Merged

fix for #1407 #1408

merged 3 commits into from
Jul 13, 2024

Conversation

FrankMittelbach
Copy link
Member

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)?
  • ltnewsX.tex (and/or latexchanges.tex) updated

Copy link
Contributor

@car222222 car222222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure that I have understood all of this text; but hoping my suggestions are nevertheless useful!

base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/ltmiscen.dtx Outdated Show resolved Hide resolved
base/ltmiscen.dtx Outdated Show resolved Hide resolved
base/ltmiscen.dtx Outdated Show resolved Hide resolved
Copy link
Contributor

@car222222 car222222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still some typos, and a query! Very sorry.

base/doc/ltnews40.tex Outdated Show resolved Hide resolved
base/doc/ltnews40.tex Outdated Show resolved Hide resolved
@FrankMittelbach
Copy link
Member Author

Still some typos, and a query! Very sorry.

no problem, I know that would be happening if I mark you a reviewer, so ... :-)

Copy link
Contributor

@car222222 car222222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still awaiting a review from @davidcarlisle, I think!

@FrankMittelbach FrankMittelbach merged commit 79583f9 into develop Jul 13, 2024
82 checks passed
@FrankMittelbach FrankMittelbach deleted the gh1407 branch July 13, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants