Gh1399 Trim spaces from envname #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzimuzhi
commented
Jul 6, 2024
Comment on lines
633
to
642
| \cs_new_protected:Npn \@@_declare_env:nnnn #1#2 | ||
| { | ||
| \str_set:Nx \l_@@_environment_str {#1} | ||
| \str_set:Nx \l_@@_environment_str | ||
| { \tl_trim_spaces:o { \l_@@_environment_str } } | ||
| \cs_if_exist:cTF { \l_@@_environment_str } | ||
| { | ||
| \msg_info:nnxx { cmd } { redefine-env } | ||
| { \l_@@_environment_str } { \tl_to_str:n {#2} } | ||
| } | ||
| { | ||
| \msg_info:nnxx { cmd } { define-env } | ||
| { \l_@@_environment_str } { \tl_to_str:n {#2} } | ||
| } | ||
| \str_set:Nn \l_@@_environment_str {#1} | ||
| \cs_if_exist:cTF { #1 } | ||
| { \msg_info:nnnn { cmd } { redefine-env } { #1 } { #2 } } | ||
| { \msg_info:nnnn { cmd } { define-env } { #1 } { #2 } } | ||
| \bool_set_false:N \l_@@_expandable_bool | ||
| \bool_set_true:N \l_@@_environment_bool | ||
| \exp_args:NV \@@_declare_env_internal:nnnn | ||
| \l_@@_environment_str {#2} | ||
| \@@_declare_env_internal:nnnn {#1} {#2} | ||
| } |
There was a problem hiding this comment.
A tiny difference: before str (the content of \l_@@_environment_str) is used, now tl (the expansion result of \tl_trim_spaces:e { <envname> }) is used.
As the fully-expanded, space-trimmed <envname> is either used in csname or message, this change shouldn't affect behavior of code.
josephwright
approved these changes
Jul 6, 2024
muzimuzhi
added a commit
to muzimuzhi/latex2e
that referenced
this pull request
Jul 6, 2024
davidcarlisle
pushed a commit
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1399.
Internal housekeeping
Status of pull request
Checklist of required changes before merge will be approved
\changesentries in source includedchanges.txtupdatedltnewsX.tex(and/orlatexchanges.tex) updated