Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set tracinglostchars for #1380 #1381

Merged
merged 3 commits into from
Jun 17, 2024
Merged

set tracinglostchars for #1380 #1381

merged 3 commits into from
Jun 17, 2024

Conversation

davidcarlisle
Copy link
Member

@davidcarlisle davidcarlisle commented Jun 17, 2024 •
edited by FrankMittelbach

Internal housekeeping

Status of pull request

  • Ready to merge

Checklist of required changes before merge will be approved

  • Test file(s) added
  • Version and date string updated in changed source files
  • Relevant \changes entries in source included
  • Relevant changes.txt updated
  • [n/a] Rollback provided (if necessary)? not needed I think, there is already rollback to pre 2017 version
  • ltnewsX.tex (and/or latexchanges.tex) updated

@davidcarlisle davidcarlisle self-assigned this Jun 17, 2024
FrankMittelbach
FrankMittelbach approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@FrankMittelbach FrankMittelbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me (with one query)

base/testfiles-TU/github-1380.luatex.tlg Outdated Show resolved Hide resolved
@davidcarlisle davidcarlisle merged commit 82af2e8 into develop Jun 17, 2024
82 checks passed
@davidcarlisle davidcarlisle deleted the gh1380 branch June 17, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankMittelbach FrankMittelbach FrankMittelbach approved these changes

Assignees

@davidcarlisle davidcarlisle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidcarlisle @FrankMittelbach