Add options to unused list when unknown key is active #1184
Conversation
josephwright
force-pushed
the
gh1183
branch
3 times, most recently
from
6aec8f3
to
fb61912
Compare
|
|
||
| \endinput | ||
| \end{filecontents} | ||
| \documentclass[a4paper,test=wtf,bertha]{github-1183} |
There was a problem hiding this comment.
Use an extra option which is unknown to both article and githu-1183 classes, to trigger the "Unused global option(s)" waning?
There was a problem hiding this comment.
We still shouldn't see a warning?
There was a problem hiding this comment.
From a conceptual point I think that global options should be handled as follows:
- if a package uses a global option it is marked as used (but still offered to other packages as a global option)
- if no package uses a global option there should be an "unused global option warning"
The big question is what does this mean if a a package defines an unknown option handler?
- Given that for the default unknown option handler (raising an unknown option error) global options are ignored one can argue that the same should happen if a different unknown option handler is implemented
- Another possibility is to pass global options to an unknown option handler (if it is not the default) and consider them used if that happens (that means that with one such package we would automatically use all global options and there is no warning ever)
- Finally one could implement some sort of a mix of the two by offering an interface to be used in the unknown option handler to explicitly mark a global option as used if it is passed through and is handled (not sure how that should look like exactly)
There was a problem hiding this comment.
We still shouldn't see a warning?
@josephwright I'm not sure which behavior is expected (#1183 has some discussions on it), but with current proposed change, if aaapaper is used as class option, it will remain in unused options list. See muzimuzhi@5875883.
|
This PR has been automatically marked as stale because it has not had recent activity. |
No description provided.