Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix php5 support #7

Closed
wants to merge 1 commit into from
Closed

fix php5 support #7

wants to merge 1 commit into from

Conversation

michabbb
Copy link

@michabbb michabbb commented Aug 6, 2017

illuminate/support 5.1 is only compatible with php7 because of using the "coalescing operator" (??)

illuminate/support 5.1 is only compatible with php7 because of using the "coalescing operator" (??)
@michabbb
Copy link
Author

michabbb commented Aug 6, 2017

with php 5.6 i get the error Parse error: syntax error, unexpected '?' in vendor/illuminate/support/Arr.php on line 289

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.104% when pulling 33c4037 on michabbb:master into 87fe17e on laravie:master.

@crynobone
Copy link
Member

No, illuminate/support 5.1 support 5.5 and above.

https://packagist.org/packages/illuminate/support#v5.1.41

@crynobone crynobone closed this Aug 7, 2017
@michabbb
Copy link
Author

michabbb commented Aug 7, 2017

@crynobone okay, thanks for the info, something went wrong here, because my composer require command installed a version of illuminate/support that only supports php7 - i will check that....

@crynobone
Copy link
Member

https://travis-ci.org/laravie/parser

We are testing this package against PHP 5.5, 5.6, 7.0, 7.1, 7.2 and HHVM. If any of the combination is incompatible the tests would fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants