Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

castValue will return array of values when last tag has several occurrences #34

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

BigOHenry
Copy link
Contributor

When last tag has multiple occurrences, now only the first one is returned as string:

......
    <Detail>
        <DynPar>T0019:2,R0109:test2,R0108:,R0107:,T0025:X</DynPar>
        <DynPar>T0019:3,R0109:test3,R0108:,R0107:,T0025:Y</DynPar>
    </Detail>
....

Current result is only value from first tag:
'DynPar' => 'T0019:2,R0109:test2,R0108:,R0107:,T0025:X',

After this commit, it will return array of values:

'DynPar' => [
        'T0019:2,R0109:test2,R0108:,R0107:,T0025:X',
        'T0019:3,R0109:test3,R0108:,R0107:,T0025:Y',
    ],

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 95.122% when pulling a0998ca on BigOHenry:2.x into ac12ff5 on laravie:2.x.

@onelazydev
Copy link

Hey,

This resolved an issue I was having with parsing DDEX XML files, so was wondering if there was any timeline for implementation, or perhaps even a reason that it's unsuitable to be added for now.

@crynobone crynobone merged commit b47d617 into laravie:2.x Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants