Support 3 levels of array inside the xml #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be somthig like that 'product' => ['uses' => 'T_NEW_CATALOG.PRODUCT[KNOTEN_ID>node_id,NAME>name,PRODUCT_DETAILS{DESCRIPTION_SHORT>short,EAN>ean}>details]']
|
This definitely require new tests before being merged |
|
Resubmit PR with tests. I can't maintain this code unless I know what exactly does it covers. Otherwise any future modification of the code might break this because we never tests against it. |
|
Ok, i will write the test case and submit it as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the code to support 3 levels of array inside the xml, so it will be somthig like that
'product' => ['uses' => 'T_NEW_CATALOG.PRODUCT[KNOTEN_ID>node_id,NAME>name,PRODUCT_DETAILS{DESCRIPTION_SHORT>short,EAN>ean}>details]']