Use custom TeamInvitation model in TeamInvitationController #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@driesvints hope that is all correctly configured and the way of contributing to the next major release. |
|
Do we need some information/text on how to upgrade? |
Zen0x7
added a commit
to Zen0x7/jetstream
that referenced
this pull request
Oct 18, 2021
GeoSot
pushed a commit
to GeoSot/jetstream
that referenced
this pull request
Jan 11, 2022
GeoSot
pushed a commit
to GeoSot/jetstream
that referenced
this pull request
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the custom
TeamInvitationclass in theacceptanddestroymethods of theTeamInvitationControllerto retrieve the invitation model.Motivation
Fixes #890.
Solution
BREAKING: Removes the type-hint from the controller methods. Therefore the model will not be resolved by the framework and the invitation id will be passed to the controller. Uses the invitation id and the Jetstream helper to query and retrieve an instance of the custom
TeamInvitation. UsesfirstOrFailas the route model binding responds with aModelNotFoundExceptionas well when an invalid id is passed.