Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused dependency from composer.json #846

Merged
merged 1 commit into from
Jul 28, 2021
Merged

remove unused dependency from composer.json #846

merged 1 commit into from
Jul 28, 2021

Conversation

romsar
Copy link
Contributor

@romsar romsar commented Jul 28, 2021 •
edited
Loading

#845
Now we use Laravel's \Str::markdown instead of this dependency and we don't need it.

@driesvints
Copy link
Member

@RomanSarvarov please always provide a description to a PR so Taylor knows what this is about and don't link to an issue (see the PR template).

@driesvints driesvints closed this Jul 28, 2021
@driesvints driesvints reopened this Jul 28, 2021
@romsar
Copy link
Contributor Author

romsar commented Jul 28, 2021 •
edited
Loading

Sure, thank you!

@romsar romsar closed this Jul 28, 2021
@romsar
Copy link
Contributor Author

romsar commented Jul 28, 2021

Just noticed that you reopened this PR.

@romsar romsar reopened this Jul 28, 2021
@taylorotwell taylorotwell merged commit 5a9d475 into laravel:2.x Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romsar @driesvints @taylorotwell